ADS: Lint Rules #2697
Merged
ADS: Lint Rules #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2023
Merged
Merged
Closed
Merged
Closed
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
malmstein
force-pushed
the
feature/david/ads_release
branch
from
88513f0
to
38a6079
Compare
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
from
c6fecec
to
f911804
Compare
Merged
nalcalag
force-pushed
the
feature/david/ads_release
branch
from
38a6079
to
5127ff0
Compare
malmstein
force-pushed
the
feature/david/ads_release
branch
from
e17a3c9
to
a41b936
Compare
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
from
f911804
to
7066d59
Compare
malmstein
force-pushed
the
feature/david/ads_release
branch
from
a41b936
to
33cfac4
Compare
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
from
7066d59
to
0c189d4
Compare
malmstein
force-pushed
the
feature/david/ads_release
branch
from
3316e4f
to
1479b59
Compare
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
from
0c189d4
to
67edec2
Compare
malmstein
force-pushed
the
feature/david/ads_release
branch
from
dfdeedc
to
0efeb10
Compare
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
2 times, most recently
from
a378463
to
df43a34
Compare
malmstein
force-pushed
the
feature/david/ads_release
branch
from
227368b
to
e636ebb
Compare
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
from
df43a34
to
5273372
Compare
malmstein
force-pushed
the
feature/david/ads_release
branch
2 times, most recently
from
09bff1e
to
bb534b4
Compare
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
from
7429e8f
to
b99c919
Compare
malmstein
force-pushed
the
feature/david/ads_release
branch
from
bb534b4
to
cbd3698
Compare
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203720277615468 ### Description ### Steps to test this PR Background Task to track the work of removing unnecessary code in the app Scope: Attributes no longer in use Remove old ButtonPrimaryRounded, ButtonSecondaryRounded, etc Remove unused styles
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203827857866586 ### Description Adds a Maestro test to open the ADS Preview pages whenever a change to a Component happens ### Steps to test this PR _Non Android 13 device_ - [ ] Fresh install InternalRelease or InternalDebug version - [ ] Run maestro tests locally (❯ maestro test .maestro/ads_preview_flows/1-_design-system-components.yaml) --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1203827857866586
malmstein
force-pushed
the
01-09-feature/david/ads/lint_rules
branch
from
1402f71
to
5906404
Compare
nalcalag
requested changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203399378949473
Description
Set of Lint rules to help develop using the new Android Design System:
Loads of unused resources and attributes have been removed.
The baseline files have been updated to match the new rules.
Steps to test this PR
Run .
/gradleW lint