Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADS: Maestro #2783

Merged

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Jan 27, 2023

Task/Issue URL: https://app.asana.com/0/1174433894299346/1203827857866586

Description

Adds a Maestro test to open the ADS Preview pages whenever a change to a Component happens

Steps to test this PR

Non Android 13 device

  • Fresh install InternalRelease or InternalDebug version
  • Run maestro tests locally (❯ maestro test .maestro/ads_preview_flows/1-_design-system-components.yaml)

@malmstein malmstein marked this pull request as ready for review January 27, 2023 14:35
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@malmstein malmstein merged commit 4702be3 into 01-09-feature/david/ads/lint_rules Jan 27, 2023
@malmstein malmstein deleted the 01-27-feature/david/ads/maestro branch January 27, 2023 15:05
malmstein added a commit that referenced this pull request Jan 30, 2023
Task/Issue URL:
https://app.asana.com/0/1174433894299346/1203827857866586

### Description
Adds a Maestro test to open the ADS Preview pages whenever a change to a
Component happens


### Steps to test this PR

_Non Android 13 device_
- [ ] Fresh install InternalRelease or InternalDebug version
- [ ] Run maestro tests locally (❯ maestro test
.maestro/ads_preview_flows/1-_design-system-components.yaml)


---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1203827857866586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants