-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pixels for autocomplete #4357
Merged
CrisBarreiro
merged 2 commits into
feature/cbarreiro/autocomplete/add-bottom-section
from
feature/cbarreiro/autocomplete/add-pixels
Apr 30, 2024
Merged
Add pixels for autocomplete #4357
CrisBarreiro
merged 2 commits into
feature/cbarreiro/autocomplete/add-bottom-section
from
feature/cbarreiro/autocomplete/add-pixels
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on Graphite |
This was referenced Mar 26, 2024
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-pixels
branch
2 times, most recently
from
March 26, 2024 11:37
d05f3d1
to
627f283
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-pixels
branch
from
April 3, 2024 13:29
627f283
to
ada80bd
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-bottom-section
branch
from
April 5, 2024 10:30
1cd3d22
to
bc4dc30
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-pixels
branch
from
April 5, 2024 10:30
ada80bd
to
2413b01
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-bottom-section
branch
from
April 10, 2024 13:31
bc4dc30
to
ea79429
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-pixels
branch
from
April 10, 2024 13:31
2413b01
to
bfdb2e6
Compare
23 tasks
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-bottom-section
branch
from
April 10, 2024 17:26
ea79429
to
84d0b35
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-pixels
branch
from
April 10, 2024 17:26
bfdb2e6
to
a3a6ce9
Compare
This was referenced Apr 10, 2024
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-bottom-section
branch
from
April 11, 2024 10:49
84d0b35
to
f36a6ca
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-pixels
branch
from
April 11, 2024 10:49
a3a6ce9
to
5b07ffc
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-bottom-section
branch
from
April 23, 2024 11:43
f36a6ca
to
e3836ef
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/add-pixels
branch
from
April 23, 2024 11:43
5b07ffc
to
041a68e
Compare
This was referenced Apr 23, 2024
Task/Issue URL: https://app.asana.com/0/1205008441501016/1206816228247418/f ### Description ### Steps to test this PR _Website (not SERP)_ - [ ] Visit a page (not SERP) - [ ] Open the history database using inspector or flipper, and check there's a new entry in `history_entries`. Take note of the ID. Check the title field contains the same title as the tab, the query field is empty and `isSerp` is 0 - [ ] Check there's an entry in `visits_list` with that same `historyEntryId` - [ ] Reload the page - [ ] Check the `history_entries` table still has only one entry for that site - [ ] Check the `visits_list` contains 2 entries for that same `historyEntryId` _SERP_ - [ ] Perform a search - [ ] Open the history database using inspector or flipper, and check there's a new entry in `history_entries`. Take note of the ID. Check the title field contains the same title as the tab, the query field contains your query, and `isSerp` is 0 - [ ] Check there's an entry in `visits_list` with that same `historyEntryId` - [ ] Reload the page - [ ] Check the `history_entries` table still has only one entry for that site (In some cases, reload doesn't produce the same exact query params,* in case a second entry is added, check URLs are different) - [ ] Check the `visits_list` contains 2 entries for that same `historyEntryId` _DuckDuckGo URL (not SERP)_ - [ ] Visit https://duckduckgo.com/settings - [ ] Open the history database using inspector or flipper, and check the query field is empty and `isSerp` is 0 **Clear app data between tests, fire button doesn't clear history (yet)** _Feature 1_ - [ ] Visit wikipedia.org - [ ] Type wiki - [ ] Check a history result is shown for wikipedia.org _Feature 2_ - [ ] Visit https://en.wikipedia.org/wiki/Cat - [ ] Type wiki - [ ] Check there's no top hits result for Cat at wikipedia - [ ] Visit https://en.wikipedia.org/wiki/Cat 3 more times - [ ] Check there's a top hits result for Cat at wikipedia _Feature 3_ - [ ] Add a random site as a bookmark - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the URL and Wikipedia as the title - [ ] Type wiki - [ ] Check wikipedia is shown on the bottom section with a bookmark icon, not in top hits - [ ] Visit wikipedia.org - [ ] Check now wikipedia is shown in top hits with the bookmark icon _Feature 4_ - [ ] Add a random site as a favorite - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the URL and Wikipedia as the title - [ ] Type wiki - [ ] Check now wikipedia is shown in top hits with the favorite icon _Feature 5_ - [ ] Type something on the search bar - [ ] Check history/bookmark/favorite suggestions aren't shown before search suggestions are loaded _Feature 6_ - [ ] Type something on the search bar - [ ] Quickly delete everything - [ ] Check history/bookmark/favorite suggestions aren't shown before search suggestions and no "No suggestions found" message is shown either ### UI changes [No UI changes](https://github.com/duckduckgo/Android/assets/6297834/645d3666-82a0-490a-9bf6-02901d14a117)
CrisBarreiro
merged commit Apr 30, 2024
3bc5013
into
feature/cbarreiro/autocomplete/add-bottom-section
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206816228247407/f
Description
Add pixels for autocomplete
Steps to test this PR
Test pixel fired when selecting a favorite
Test pixel fired when selecting a bookmark
Website (not SERP)
history_entries
. Take note of the ID. Check the title field contains the same title as the tab, the query field is empty andisSerp
is 0visits_list
with that samehistoryEntryId
history_entries
table still has only one entry for that sitevisits_list
contains 2 entries for that samehistoryEntryId
SERP
history_entries
. Take note of the ID. Check the title field contains the same title as the tab, the query field contains your query, andisSerp
is 0visits_list
with that samehistoryEntryId
history_entries
table still has only one entry for that site (In some cases, reload doesn't produce the same exact query params,* in case a second entry is added, check URLs are different)visits_list
contains 2 entries for that samehistoryEntryId
DuckDuckGo URL (not SERP)
isSerp
is 0Clear app data between tests, fire button doesn't clear history
(yet)
Feature 1
Feature 2
Feature 3
URL and Wikipedia as the title
icon, not in top hits
Feature 4
URL and Wikipedia as the title
Feature 5
search suggestions are loaded
Feature 6
search suggestions and no "No suggestions found" message is shown either
UI changes
wikipedia_history.mp4