Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixels for autocomplete #4357

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Mar 26, 2024

Task/Issue URL: https://app.asana.com/0/0/1206816228247407/f

Description

Add pixels for autocomplete

Steps to test this PR

Test pixel fired when selecting a favorite

  • Select a favorite from autocomplete
  • Check m_autocomplete_favorite_selection has been fired

Test pixel fired when selecting a bookmark

  • Select a bookmark from autocomplete
  • Checkk m_aut_s_b has been fired

Website (not SERP)

  • Visit a page (not SERP)
  • Open the history database using inspector or flipper, and check there's a new entry in history_entries. Take note of the ID. Check the title field contains the same title as the tab, the query field is empty and isSerp is 0
  • Check there's an entry in visits_list with that same historyEntryId
  • Reload the page
  • Check the history_entries table still has only one entry for that site
  • Check the visits_list contains 2 entries for that same historyEntryId

SERP

  • Perform a search
  • Open the history database using inspector or flipper, and check there's a new entry in history_entries. Take note of the ID. Check the title field contains the same title as the tab, the query field contains your query, and isSerp is 0
  • Check there's an entry in visits_list with that same historyEntryId
  • Reload the page
  • Check the history_entries table still has only one entry for that site (In some cases, reload doesn't produce the same exact query params,* in case a second entry is added, check URLs are different)
  • Check the visits_list contains 2 entries for that same historyEntryId

DuckDuckGo URL (not SERP)

Clear app data between tests, fire button doesn't clear history
(yet)

Feature 1

  • Visit wikipedia.org
  • Type wiki
  • Check a history result is shown for wikipedia.org

Feature 2

Feature 3

  • Add a random site as a bookmark
  • Then go to bookmarks and edit it, Set https://wikipedia.org as the
    URL and Wikipedia as the title
  • Type wiki
  • Check wikipedia is shown on the bottom section with a bookmark
    icon, not in top hits
  • Visit wikipedia.org
  • Check now wikipedia is shown in top hits with the bookmark icon

Feature 4

  • Add a random site as a favorite
  • Then go to bookmarks and edit it, Set https://wikipedia.org as the
    URL and Wikipedia as the title
  • Type wiki
  • Check now wikipedia is shown in top hits with the favorite icon

Feature 5

  • Type something on the search bar
  • Check history/bookmark/favorite suggestions aren't shown before
    search suggestions are loaded

Feature 6

  • Type something on the search bar
  • Quickly delete everything
  • Check history/bookmark/favorite suggestions aren't shown before
    search suggestions and no "No suggestions found" message is shown either

UI changes

wikipedia_history.mp4

@CrisBarreiro CrisBarreiro mentioned this pull request Mar 26, 2024
41 tasks
Copy link
Contributor Author

CrisBarreiro commented Mar 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/add-pixels branch 2 times, most recently from d05f3d1 to 627f283 Compare March 26, 2024 11:37
@CrisBarreiro CrisBarreiro mentioned this pull request Mar 27, 2024
37 tasks
@CrisBarreiro CrisBarreiro marked this pull request as ready for review April 2, 2024 16:12
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/add-pixels branch from 627f283 to ada80bd Compare April 3, 2024 13:29
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/add-bottom-section branch from 1cd3d22 to bc4dc30 Compare April 5, 2024 10:30
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/add-pixels branch from ada80bd to 2413b01 Compare April 5, 2024 10:30
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/add-bottom-section branch from bc4dc30 to ea79429 Compare April 10, 2024 13:31
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/add-pixels branch from 2413b01 to bfdb2e6 Compare April 10, 2024 13:31
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/add-bottom-section branch from ea79429 to 84d0b35 Compare April 10, 2024 17:26
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/add-pixels branch from bfdb2e6 to a3a6ce9 Compare April 10, 2024 17:26
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/add-bottom-section branch from 84d0b35 to f36a6ca Compare April 11, 2024 10:49
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/add-pixels branch from a3a6ce9 to 5b07ffc Compare April 11, 2024 10:49
Task/Issue URL:
https://app.asana.com/0/1205008441501016/1206816228247418/f

### Description

### Steps to test this PR

_Website (not SERP)_
- [ ] Visit a page (not SERP)
- [ ] Open the history database using inspector or flipper, and check
there's a new entry in `history_entries`. Take note of the ID. Check the
title field contains the same title as the tab, the query field is empty
and `isSerp` is 0
- [ ] Check there's an entry in `visits_list` with that same
`historyEntryId`
- [ ] Reload the page
- [ ] Check the `history_entries` table still has only one entry for
that site
- [ ] Check the `visits_list` contains 2 entries for that same
`historyEntryId`

_SERP_
- [ ] Perform a search
- [ ] Open the history database using inspector or flipper, and check
there's a new entry in `history_entries`. Take note of the ID. Check the
title field contains the same title as the tab, the query field contains
your query, and `isSerp` is 0
- [ ] Check there's an entry in `visits_list` with that same
`historyEntryId`
- [ ] Reload the page
- [ ] Check the `history_entries` table still has only one entry for
that site (In some cases, reload doesn't produce the same exact query
params,* in case a second entry is added, check URLs are different)
- [ ] Check the `visits_list` contains 2 entries for that same
`historyEntryId`

_DuckDuckGo URL (not SERP)_
- [ ] Visit https://duckduckgo.com/settings
- [ ] Open the history database using inspector or flipper, and check
the query field is empty and `isSerp` is 0

**Clear app data between tests, fire button doesn't clear history
(yet)**

_Feature 1_
- [ ] Visit wikipedia.org
- [ ] Type wiki
- [ ] Check a history result is shown for wikipedia.org

_Feature 2_
- [ ] Visit https://en.wikipedia.org/wiki/Cat
- [ ] Type wiki
- [ ] Check there's no top hits result for Cat at wikipedia
- [ ] Visit https://en.wikipedia.org/wiki/Cat 3 more times
- [ ] Check there's a top hits result for Cat at wikipedia

_Feature 3_
- [ ] Add a random site as a bookmark
- [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the
URL and Wikipedia as the title
- [ ] Type wiki
- [ ] Check wikipedia is shown on the bottom section with a bookmark
icon, not in top hits
- [ ] Visit wikipedia.org
- [ ] Check now wikipedia is shown in top hits with the bookmark icon

_Feature 4_
- [ ] Add a random site as a favorite
- [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the
URL and Wikipedia as the title
- [ ] Type wiki
- [ ] Check now wikipedia is shown in top hits with the favorite icon

_Feature 5_

- [ ] Type something on the search bar
- [ ] Check history/bookmark/favorite suggestions aren't shown before
search suggestions are loaded

_Feature 6_
- [ ] Type something on the search bar
- [ ] Quickly delete everything
- [ ] Check history/bookmark/favorite suggestions aren't shown before
search suggestions and no "No suggestions found" message is shown either

### UI changes
[No UI
changes](https://github.com/duckduckgo/Android/assets/6297834/645d3666-82a0-490a-9bf6-02901d14a117)
@CrisBarreiro CrisBarreiro merged commit 3bc5013 into feature/cbarreiro/autocomplete/add-bottom-section Apr 30, 2024
4 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cbarreiro/autocomplete/add-pixels branch April 30, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants