adds internal setting for history #4599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4341) Task/Issue URL: https://app.asana.com/0/0/1206816228247419/f Copy the scoring algorithm from BSK _Bookmarks shouldn't show in top hits (top section, above DDG suggestions)_ - [ ] Add wikipedia.org as a bookmark (not favorite) - [ ] Type wiki on the search bar - [ ] Check the newly added bookmark is not shown in top hits, and is instead shown in the bottom section (below DDG suggestions) _Favorites should show in top hits_ - [ ] Add wikipedia.org as a favorite - [ ] Type wiki on the search bar - [ ] Check the newly added favorite is shown in top hits and uses the bookmark+favorite icon _Test pixel fired when selecting a favorite_ - [ ] Select a favorite from autocomplete - [ ] Check m_autocomplete_favorite_selection has been fired _Test pixel fired when selecting a bookmark_ - [ ] Select a bookmark from autocomplete - [ ] Checkk m_aut_s_b has been fired _Website (not SERP)_ - [ ] Visit a page (not SERP) - [ ] Open the history database using inspector or flipper, and check there's a new entry in `history_entries`. Take note of the ID. Check the title field contains the same title as the tab, the query field is empty and `isSerp` is 0 - [ ] Check there's an entry in `visits_list` with that same `historyEntryId` - [ ] Reload the page - [ ] Check the `history_entries` table still has only one entry for that site - [ ] Check the `visits_list` contains 2 entries for that same `historyEntryId` _SERP_ - [ ] Perform a search - [ ] Open the history database using inspector or flipper, and check there's a new entry in `history_entries`. Take note of the ID. Check the title field contains the same title as the tab, the query field contains your query, and `isSerp` is 0 - [ ] Check there's an entry in `visits_list` with that same `historyEntryId` - [ ] Reload the page - [ ] Check the `history_entries` table still has only one entry for that site (In some cases, reload doesn't produce the same exact query params,* in case a second entry is added, check URLs are different) - [ ] Check the `visits_list` contains 2 entries for that same `historyEntryId` _DuckDuckGo URL (not SERP)_ - [ ] Visit https://duckduckgo.com/settings - [ ] Open the history database using inspector or flipper, and check the query field is empty and `isSerp` is 0 **Clear app data between tests, fire button doesn't clear history (yet)** _Feature 1_ - [ ] Visit wikipedia.org - [ ] Type wiki - [ ] Check a history result is shown for wikipedia.org _Feature 2_ - [ ] Visit https://en.wikipedia.org/wiki/Cat - [ ] Type wiki - [ ] Check there's no top hits result for Cat at wikipedia - [ ] Visit https://en.wikipedia.org/wiki/Cat 3 more times - [ ] Check there's a top hits result for Cat at wikipedia _Feature 3_ - [ ] Add a random site as a bookmark - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the URL and Wikipedia as the title - [ ] Type wiki - [ ] Check wikipedia is shown on the bottom section with a bookmark icon, not in top hits - [ ] Visit wikipedia.org - [ ] Check now wikipedia is shown in top hits with the bookmark icon _Feature 4_ - [ ] Add a random site as a favorite - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the URL and Wikipedia as the title - [ ] Type wiki - [ ] Check now wikipedia is shown in top hits with the favorite icon _Feature 5_ - [ ] Type something on the search bar - [ ] Check history/bookmark/favorite suggestions aren't shown before search suggestions are loaded _Feature 6_ - [ ] Type something on the search bar - [ ] Quickly delete everything - [ ] Check history/bookmark/favorite suggestions aren't shown before search suggestions and no "No suggestions found" message is shown either [Video](https://github.com/duckduckgo/Android/assets/6297834/645d3666-82a0-490a-9bf6-02901d14a117)  
Task/Issue URL: https://app.asana.com/0/0/1207300113417901/f ### Description ### Steps to test this PR _Feature 1_ - [ ] Do a clean install - [ ] Visit wikipedia.org - [ ] Save it as bookmark - [ ] Visit wikimedia.org - [ ] Save it as favorite - [ ] Use the fire button - [ ] Type wiki - [ ] Check wikimedia (favorite) is the first result in top hits, and wikipedia (bookmark) is the second _Feature 1_ - [ ] Do a clean install - [ ] Visit wikipedia.org - [ ] Save it as bookmark - [ ] Type wiki - [ ] Check wikipedia is shown in top hits ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
…ton (#4450) Task/Issue URL: https://app.asana.com/0/1205008441501016/1206832755470649/f ### Description See title ### Steps to test this PR _Feature 1_ - [ ] Visit wikipedia.org - [ ] Type wiki - [ ] Check wikipedia.org shows as a history suggestion - [ ] Press fire button - [ ] Type wiki again - [ ] Check wikipedia.org isn't shown as a history suggestion anymore
This was referenced May 30, 2024
Merged
Merged
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @cmonfortep and the rest of your teammates on |
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/history-entry
branch
3 times, most recently
from
6a64977
to
b004e64
Compare
Base automatically changed from
feature/cbarreiro/autocomplete/history-entry
to
develop
June 5, 2024 09:59
|
The Purge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207446334590373/f
Description
Steps to test this PR
Feature 1
UI changes