Clear history entries from memory and database when clicking fire button #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2024
Merged
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on |
6 tasks
CrisBarreiro
changed the title
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
172b303
to
c391a17
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/defer-local-results
branch
from
3e52f95
to
8a65e96
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
c391a17
to
5ad8558
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/defer-local-results
branch
from
8a65e96
to
b8dbb92
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
5ad8558
to
17efc3b
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/defer-local-results
branch
from
b8dbb92
to
ff1d23d
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
2 times, most recently
from
34610cf
to
1179474
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/defer-local-results
branch
from
ff1d23d
to
5c6c1f9
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
1179474
to
137874e
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/defer-local-results
branch
from
5c6c1f9
to
dba53d9
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
137874e
to
28eed47
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/defer-local-results
branch
from
dba53d9
to
e9a67c9
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
28eed47
to
f43ecc1
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/defer-local-results
branch
from
e9a67c9
to
0d2bfa3
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
5a21ae9
to
67be27a
Compare
16 tasks
cmonfortep
reviewed
May 6, 2024
| @@ -42,4 +42,8 @@ class RealNavigationHistory @Inject constructor( | |||
| override fun getHistorySingle(): Single<List<HistoryEntry>> { | |||
| return historyRepository.getHistoryObservable() | |||
| } | |||
|
|
|||
| override suspend fun clearHistory() { | |||
There was a problem hiding this comment.
NIT: if we make it suspend, it's best if we enforce dispatcher here. Just adding withContext(dispatcher.io())
There was a problem hiding this comment.
No strong opinions, but why here and not on the repository?
27 tasks
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/history-entry
branch
from
cb0235c
to
c2caede
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
2 times, most recently
from
8a2b4ad
to
e8d4f44
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/history-entry
branch
from
34f2ced
to
38500c8
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
e8d4f44
to
6831b27
Compare
This was referenced May 20, 2024
Merged
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
6831b27
to
6c0af8e
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/history-entry
branch
from
42974d1
to
cdc35c9
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
6c0af8e
to
615f20b
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
615f20b
to
3c1ac6e
Compare
CrisBarreiro
changed the base branch from
feature/cbarreiro/autocomplete/history-entry
to
feature/cbarreiro/autocomplete/allow-bookmarks-in-top-hits
Base automatically changed from
feature/cbarreiro/autocomplete/allow-bookmarks-in-top-hits
to
feature/cbarreiro/autocomplete/history-entry
May 22, 2024 14:23
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/history-entry
branch
from
39db003
to
9ce7fa6
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
3c1ac6e
to
9648c7f
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/history-entry
branch
from
9ce7fa6
to
b57edfa
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
from
9648c7f
to
dad2991
Compare
Task/Issue URL: https://app.asana.com/0/0/1206969865711357/f ### Description See title ### Steps to test this PR Checkout this branch, go to HistoryDeletionWorker, and modify scheduleWorker adding setInitialDelay(5, TimeUnit.Minutes). Clear app data afterwards _Feature 1_ - Checkout this branch, go to `HistoryDeletionWorker`, and modify `scheduleWorker` adding `setInitialDelay(5, TimeUnit.Minutes)` - [ ] Go to `RealNavigationHistory` and modify `historyRepository.clearEntriesOlderThan(currentTimeProvider.localDateTimeNow().minusDays(30))`, changing `minusDays(30)` to `minusMinutes (2)` - [ ] Add a log so you know deletion is happening - [ ] Do a fresh install - [ ] Open app - [ ] Browse normally for a few minutes - [ ] Check that after ~5 minutes the log is shown and items older than 2 minutes are removed. Note that, if a site has several visits and some of them are more recent than the threshold for removal, only old visits will be removed, but both the entry entity and the recent visits will remain ### UI changes N/A
CrisBarreiro
merged commit f09e64b
into
feature/cbarreiro/autocomplete/history-entry
4 checks passed
CrisBarreiro
deleted the
feature/cbarreiro/autocomplete/clear-on-fire-button
branch
cmonfortep
pushed a commit
that referenced
this pull request
May 30, 2024
…ton (#4450) Task/Issue URL: https://app.asana.com/0/1205008441501016/1206832755470649/f ### Description See title ### Steps to test this PR _Feature 1_ - [ ] Visit wikipedia.org - [ ] Type wiki - [ ] Check wikipedia.org shows as a history suggestion - [ ] Press fire button - [ ] Type wiki again - [ ] Check wikipedia.org isn't shown as a history suggestion anymore
CrisBarreiro
added a commit
that referenced
this pull request
May 31, 2024
…ton (#4450) Task/Issue URL: https://app.asana.com/0/1205008441501016/1206832755470649/f ### Description See title ### Steps to test this PR _Feature 1_ - [ ] Visit wikipedia.org - [ ] Type wiki - [ ] Check wikipedia.org shows as a history suggestion - [ ] Press fire button - [ ] Type wiki again - [ ] Check wikipedia.org isn't shown as a history suggestion anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205008441501016/1206832755470649/f
Description
See title
Steps to test this PR
Feature 1