Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer local results until remote ones are available #4420

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Defer local results until remote ones are available #4420

merged 2 commits into from
Apr 30, 2024

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Apr 11, 2024 •
edited

Task/Issue URL: https://app.asana.com/0/0/1206889126871834/f

Description

Defer local results until remote ones are available

Steps to test this PR

Feature 1

  • Type something on the search bar
  • Check history/bookmark/favorite suggestions aren't shown before search suggestions are loaded

Feature 1

  • Type something on the search bar
  • Quickly delete everything
  • Check history/bookmark/favorite suggestions aren't shown before search suggestions and no "No suggestions found" message is shown either

This was referenced Apr 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@CrisBarreiro Graphite App
Copy link
Contributor Author

CrisBarreiro commented Apr 11, 2024 •
edited by cmonfortep

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

@CrisBarreiro CrisBarreiro mentioned this pull request Apr 11, 2024
Merged
@CrisBarreiro CrisBarreiro changed the title Add history results to autocomplete suggestions Defer local results until remote ones are available Apr 11, 2024
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from e0a7632 to fb7e00b Compare April 11, 2024 10:50
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from c268150 to 8ad46c8 Compare April 11, 2024 10:50
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from fb7e00b to 9a16704 Compare April 11, 2024 15:23
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from 8ad46c8 to a7995cb Compare April 11, 2024 15:24
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 9a16704 to 23fa1e7 Compare April 11, 2024 15:38
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from a7995cb to 704b51c Compare April 11, 2024 15:38
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 23fa1e7 to f279378 Compare April 11, 2024 16:35
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from 704b51c to 3b5ab4e Compare April 11, 2024 16:35
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from f279378 to bb917c9 Compare April 11, 2024 16:48
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from 3b5ab4e to d2c0ded Compare April 11, 2024 16:48
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from bb917c9 to ad38129 Compare April 12, 2024 08:34
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from d2c0ded to 9975ae4 Compare April 12, 2024 08:34
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from ad38129 to 398262e Compare April 12, 2024 08:59
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch 2 times, most recently from 57c8839 to 22f61d7 Compare April 12, 2024 11:11
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from de9aced to 30e7102 Compare April 23, 2024 11:44
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from 22f61d7 to 3e52f95 Compare April 23, 2024 11:44
This was referenced Apr 23, 2024
Merged
Merged
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from 3e52f95 to 8a65e96 Compare April 24, 2024 11:47
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 30e7102 to 8ea83d2 Compare April 25, 2024 11:34
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from 8a65e96 to b8dbb92 Compare April 25, 2024 11:34
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 8ea83d2 to 68776eb Compare April 25, 2024 11:35
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from b8dbb92 to ff1d23d Compare April 25, 2024 11:35
@CrisBarreiro CrisBarreiro marked this pull request as ready for review April 25, 2024 11:40
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 68776eb to 2f5c590 Compare April 25, 2024 14:35
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from ff1d23d to 5c6c1f9 Compare April 25, 2024 14:35
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 2f5c590 to 1c41e69 Compare April 25, 2024 15:01
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from 5c6c1f9 to dba53d9 Compare April 25, 2024 15:01
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from dba53d9 to e9a67c9 Compare April 29, 2024 12:36
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 6aed08b to 27d7dc4 Compare April 29, 2024 14:30
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/defer-local-results branch from e9a67c9 to 0d2bfa3 Compare April 29, 2024 14:30
@CrisBarreiro CrisBarreiro merged commit e7b0759 into feature/cbarreiro/autocomplete/history-modules Apr 30, 2024
4 of 8 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cbarreiro/autocomplete/defer-local-results branch April 30, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonfortep cmonfortep Awaiting requested review from cmonfortep

Assignees

@cmonfortep cmonfortep

Labels
STACKED PR - DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CrisBarreiro @cmonfortep