-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Facebook Click to Load integration tests #1039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
kzar
force-pushed
the
fb-clicktoplay-improvetests
branch
from
February 3, 2022 17:10
bf42fdf
to
caced37
Compare
kdzwinel
reviewed
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! I left some comments, mostly nits 👀
kzar
force-pushed
the
fb-clicktoplay-improvetests
branch
2 times, most recently
from
February 4, 2022 15:51
28f40ea
to
f77d182
Compare
kdzwinel
reviewed
Feb 4, 2022
kzar
force-pushed
the
fb-clicktoplay-improvetests
branch
7 times, most recently
from
February 8, 2022 17:58
74258d3
to
cd23f06
Compare
Improvements to the Facebook Click to Load integration tests, including: 1. Reduce flaky failures by waiting until all the required extension configuration has been loaded. 2. Log requests using Puppeteer instead of relying on the test page to accurately report the number of allowed/blocked requests. 3. Test requests to the SDK are redirected properly. 4. Test that unblocking works correctly and that reloading the page restores blocking. This change also: - Renames and expands on the background waiting integration test helper module. That way, we can avoid duplicating configuration waiting logic. - Tweaks the request logging helper module to avoid logging in-flight requests that started before a navigation but finished afterwards. That race condition was the cause of some test flakiness. - Tweaks the YouTube CTL tests to wait for "networkidle0" instead of "networkidle2". That means waiting for all requests to complete, rather than all but two.
kzar
force-pushed
the
fb-clicktoplay-improvetests
branch
from
February 8, 2022 18:02
cd23f06
to
30a4908
Compare
Thanks! LGTM. |
kdzwinel
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Facebook Click to Load integration tests
Improvements to the Facebook Click to Load integration tests,
including:
configuration has been loaded.
to accurately report the number of allowed/blocked requests.
restores blocking.
This change also:
helper module. That way, we can avoid duplicating configuration
waiting logic.
requests that started before a navigation but finished
afterwards. That race condition was the cause of some test flakiness.
"networkidle2". That means waiting for all requests to complete,
rather than all but two.
Reviewer: @jonathanKingston
CC: @ladamski, @Charlie-belmer, @sammacbeth, @kdzwinel
Depends on: #978
Description:
This change makes use of the YouTube Click to Load work to improve the Facebook Click to Load integration tests.
Steps to test this PR:
npm run test-int
.Automated tests:
Reviewer Checklist:
PR Author Checklist: