-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement YouTube Click to Load #978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I left some general comments but haven't tested it out yet. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback!
fd02f9c
to
f2da1a8
Compare
d651e7a
to
4de24ce
Compare
4de24ce
to
94e7e74
Compare
9410a60
to
3b95aa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just have some minor formatting comments, otherwise I don't see anything major. If you could fix the console errors in Firefox I think we'll be good to merge.
3b95aa8
to
a82de14
Compare
Add privacy protection from embedded YouTube videos and playlists. Block third-party YouTube requests and display a placeholder for the corresponding element that allows users to unblock the content again. Where possible, also upgrade embedded videos to use youtube-nocookie.com.
a82de14
to
fd51f26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes. LGTM
Add privacy protection from embedded YouTube videos and
playlists. Block third-party YouTube requests and display a
placeholder for the corresponding element that allows users to
unblock the content again. Where possible, also upgrade embedded
videos to use youtube-nocookie.com.
Reviewer: @jonathanKingston
CC: @ladamski, @kdzwinel, @Charlie-belmer, @sammacbeth
Steps to test this PR:
social_ctp_configuration.json
file: https://gist.github.com/kzar/89bc3b8971daef09334da5a0799589c0Automated tests:
Reviewer Checklist:
PR Author Checklist: