Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Ubuntu version #106

Closed
wants to merge 21 commits into from
Closed

Ubuntu version #106

wants to merge 21 commits into from

Conversation

simonft
Copy link

@simonft simonft commented Oct 28, 2012

This is the same as the Debian version, except it checks for version of packages in Ubuntu.

@ghost ghost assigned majuscule Oct 28, 2012
@jagtalon
Copy link
Member

@simonft Just a few comments on the JS code:

items = new Array();
items[0] = new Array();

would be better written as:

var items = [[]];

and the bottom part can be replaced with:

items[0] = {
    a: ...,
    h: ...,
    s: ...,
    u: ...,
    f: true
};

Oh, and maybe you don't need a new line (\n) in the HTML anymore?

out += '<table id="ubuntuVersions">\n';
...
out += '</tr>\n';

Is the document.write for debugging? Make sure you comment it out! :bowtie:

Thanks for submitting! And don't forget, JSLint is your friend!

@simonft
Copy link
Author

simonft commented Jan 21, 2013

Gah, I've not used javascript before. However, given that there seems to be another plugin that does this better, I'm going to close this pull request. Thanks.

@Getty Getty closed this Feb 11, 2013
@Getty
Copy link
Contributor

Getty commented Feb 11, 2013

@simonft you can open up a new pull request at any time if the situation changes, just doing cleanup here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants