Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): use recommended docker config for remote cache #320

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

gustavoam-asdf
Copy link
Contributor

@gustavoam-asdf gustavoam-asdf commented Mar 15, 2024

In this PR:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Issues reference:

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code with pnpm lint locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran build with pnpm build of your changes locally?
  • Have you successfully ran tests with pnpm test of your changes locally?
  • Have you commit using Conventional Commits?

@gustavoam-asdf
Copy link
Contributor Author

Use recomended config of turbo repo

@fox1t
Copy link
Collaborator

fox1t commented Mar 21, 2024

LGTM

@matteovivona
Copy link
Collaborator

@all-contributors add @gustavoam-asdf doc

Copy link
Contributor

@matteovivona

I've put up a pull request to add @gustavoam-asdf! 🎉

@matteovivona matteovivona merged commit 24a7504 into ducktors:main Mar 21, 2024
19 checks passed
@matteovivona
Copy link
Collaborator

🎉 This PR is included in version 2.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gtjamesa
Copy link
Contributor

Just FYI, the turbo docs recommend including the git directory

https://turbo.build/repo/docs/core-concepts/caching/file-inputs#turborepos-default-behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants