Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved diodes to better protect them #5

Closed
wants to merge 1 commit into from

Conversation

davenull
Copy link

I keep worrying about them.

@duckyb
Copy link
Owner

duckyb commented Apr 25, 2023

Interesting, I'll check this soon

@ToppDev
Copy link

ToppDev commented Mar 1, 2024

I am not really good at KiCad, but I wanted to add more information to this MR.

Seems like only the outmost Diods on the right half have been moved to better protect them.
They now moved under the key switch, but as they soldered on the bottom side of the PCB, this is no problem.

PCB editor

image

3D View

image

Problem

One problem with the MR I found is, that the 3D view is not updated. I could fix this by running the Design Rule Checker.

image

@duckyb
Copy link
Owner

duckyb commented Mar 1, 2024

Thanks for the preview @ToppDev
It seems like they forgot to update the fill zones before submitting this PR.
Also I agree with moving the diodes now that they will be soldered on the bottom side, but the diodes on the top surface should be removed at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants