refactor: Make option types more backwards compatible #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two option types:
ServerFlowOptions
andClientFlowOptions
. We might want to add additional fields to them in the future. It would be nice if we were able to do that without a breaking change. So I propose:#[non_exhaustive]
. This allows us to add fields.ClientFlowOptions
non-Copy
. This allos us to add non-Copy
fields.The
Codec
types inimap-codec
already do this.Caveat: To my surprise the
..
notation does not work with#[non_exhaustive]
(maybe in the future, see rust-lang/rust#70564 (comment)). So this doesn't work:Instead you need to write this:
But I'm willing to accept this.