Skip to content

feat(booking): add new fields to Order and Offer passenger data #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2021
Merged

feat(booking): add new fields to Order and Offer passenger data #291

merged 2 commits into from
Nov 23, 2021

Conversation

matthewp5
Copy link
Contributor

@matthewp5 matthewp5 commented Nov 22, 2021 •
edited
Loading

  • add family_name, given_name, and loyalty_programme_accounts fields to OfferPassenger interface
  • add loyalty_programme_accounts field to the OrderPassenger interface
  • add unit tests

@matthewp5 matthewp5 requested a review from a team as a code owner November 22, 2021 17:35
justaddcl
justaddcl approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@justaddcl justaddcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pairing with me on this one!

jesse-c
jesse-c approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@jesse-c jesse-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will the OfferRequest#Create and Offer.Passenger#Update changes be made elsewhere? Or already have been made?

@matthewp5
Copy link
Contributor Author

LGTM

Will the OfferRequest#Create and Offer.Passenger#Update changes be made elsewhere? Or already have been made?

I think those have changes have been made on these PRs: OfferRequest#Create, Offer.Passenger#Update

@matthewp5 matthewp5 merged commit f26f002 into main Nov 23, 2021
@matthewp5 matthewp5 deleted the UXP-1440-new-offer-order-data branch November 23, 2021 16:57
@github-actions
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lapa182 lapa182 Awaiting requested review from lapa182

2 more reviewers

@jesse-c jesse-c jesse-c approved these changes

@justaddcl justaddcl justaddcl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewp5 @jesse-c @justaddcl