fix(types): make rollup's dts plugin work with tsconfig's baseUrl
#377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go1t
requested review from
shaundon,
mcdeguzman99,
lapa182 and
a team
and removed request for
a team
|
@lapa182 ah I see. thank you! |
We have configured `baseUrl` in tsconfig.json, which allows absolute imports to be resolved by typescript. However, we didn't configure the same thing in the rollup config, specifically in the `dts` plugin. This led to an issue after the package was published #372. This PR adds a baseUrl configuration to ensure that absolute import can be resolved the same way during the rollup process.
go1t
force-pushed
the
remove-baseUrl-tsconfig
branch
from
b50bfbc to
7168e59
Compare
go1t
changed the title
dts plugin work with tsconfig's baseUrldts plugin work with tsconfig's baseUrl
|
🎉 This PR is included in version 1.7.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have configured
baseUrlin tsconfig.json, which allows absolute imports to be resolved by typescript. However, we didn't configure the same thing in the rollup config, specifically in thedtsplugin. This led to an issue after the package was published #372. This PR adds abaseUrlconfiguration to ensure that absolute imports can be resolved the same way during the rollup process.Fly-bys: