Fix/jk 171 loading bar #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimhjkim
added a commit
that referenced
this pull request
Dec 4, 2019
* removed cors * modified server * installed cors on server * added dev start script that uses nodemon * listening to variable port * dotenv installed and using environment variables * modified server code * frontend and backend domains defined * added _redirects file * moved _redirects file to public folder * added .env-example * prod (netlify) listens to production branch (#166) (#167) * removed cors * modified server * installed cors on server * added dev start script that uses nodemon * listening to variable port * dotenv installed and using environment variables * modified server code * frontend and backend domains defined * added _redirects file * moved _redirects file to public folder * Fix/jk 168 avatar (#169) * clicking on the avatar takes user back to account authentication page * removed spacing around loading bar * Update README.md * Fix/jk 171 loading bar (#172) * background shows while the loading bar is present * added taglines to login portal * added paddingBottom to SongDetails component: vh dependent * removed commented out console log * added git ignore files to both client and server dir * added taglines on login portal (#173) (#174) * added taglines to login portal * added paddingBottom to SongDetails component: vh dependent * removed commented out console log * merge conflict resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #171