Coupon Listing Tables #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing an issue when trying to query the coupon type as the Stache query builder breaks when comparing the values.
…edigital/simple-commerce into feature/coupon-listing-tables
…edigital/simple-commerce into feature/coupon-listing-tables
Merged
|
Released as part of v5.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a proper listing table for Coupons. This means you can now filter & search coupons, along with being able to customise the columns shown on the listing table.
Before
Now
As part of this change, I've had to change how the coupon
typeis stored in the Stache. Instead of being stored as the enum itself, it's stored as the enum's key, which is then "new-ed up" again when you do->type()on theCouponinstance.I had to make this change to allow for querying the coupon type in
CouponTypeFilter.