Fix glob #164
Merged
Fix glob #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kirillsalykin, thanks for the help. This looks cool. The nil I would love if we could somehow leverage the clj-glob test suite to make sure we cover all of the other cases like brace expansion, question mark wildcards, etc. |
|
@dundalek sci specific tests also failing on master - don't think my changes have caused it. |
|
Awesome work, seems to work great 🚀 Yeah, those sci CI errors are unrelated, they are about a functionality that needs to be yet implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes glob on JVM.
closes #158
@dundalek not sure I understand when
cwdcan be nil and why it is treated as a valid condition.