Persistent history

[dundalek]

Work in Progress

Tasks:

• Save history into sqlite
• Load up history into readline memory
• Type something then arrow up search
• Ctrl-r search
• Do not load history into memory (search via db)
• Cleanups & testing

[mnewt]

Cool. This sure will come in handy during development, when the repl is constantly restarting. I'm curious what your plans are with this. What is sqlite adding to the equation? Why not simply read a file into memory and then search in memory?

[dundalek]

Good question! The design goal I have is to get to feature completeness as soon as possible with reasonable trade-offs. The most difficult part with keeping history is synchronizing writes of multiple processes (when you have multiple shells running) into one file. You have to do low-level file locking, which may behave slightly differently across different platforms. Sqlite does its own robust file locking which makes it easy for us.