Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to customize used nix packages #26

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Ability to customize used nix packages #26

merged 8 commits into from
Sep 13, 2023

Conversation

dundalek
Copy link
Owner

@zoriya
Copy link
Contributor

zoriya commented Sep 12, 2023

Thank you for looking into this. I don't understand what

pcall(require("lspconfig").omnisharp.document_config.default_config.on_new_config, new_config, new_root_dir)

does and why the user should do it instead of lazy-lsp directly.

@dundalek
Copy link
Owner Author

Good question, it is kind of ugly, but it is to mimic the behavior of the on_new_config from lspconfig, when the user provides an override the original one is not called.

In the case of omnisharp the default function sets some parameters, so we call the original to make sure we get proper parameters before wrapping it with shell.

@zoriya
Copy link
Contributor

zoriya commented Sep 12, 2023

Okay, I see, I completely forgot about that even thought I made the original PR for that.

Thank you for implementing that!

@dundalek dundalek merged commit 01d04e2 into master Sep 13, 2023
1 check passed
@dundalek dundalek deleted the overrides branch September 13, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to override used nix package
2 participants