fix: add default value for CreateTableResult.already_existed field (#160)

Author: gududefengzhong

dune_client/models.py

@@ -369,8 +369,9 @@ class CreateTableResult(DataClassJsonMixin):
     table_name: str
     full_name: str
     example_query: str
-    already_existed: bool
     message: str
+    # kept for backward compatibility, always False, unreliable
+    already_existed: Optional[bool] = False
 
 
 @dataclass

tests/e2e/test_client.py

@@ -248,7 +248,6 @@ def test_create_table_success(self):
 
         namespace = "bh2smith"
         table_name = "dataset_e2e_test"
-
         self.assertEqual(
             client.create_table(
                 namespace=namespace,
@@ -266,6 +265,7 @@ def test_create_table_success(self):
                     "table_name": table_name,
                     "full_name": f"dune.{namespace}.{table_name}",
                     "example_query": f"select * from dune.{namespace}.{table_name} limit 10",
+                    "message": "Table created successfully",
                 }
             ),
         )
@@ -357,7 +357,7 @@ def test_delete_table_success(self):
             ),
             DeleteTableResult.from_dict(
                 {
-                    "message": "Table teamwaddah.waddah_test3 successfully deleted",
+                    "message": f"Table {namespace}.{table_name} successfully deleted",
                 }
             ),
         )

tests/unit/test_models.py

@@ -17,6 +17,7 @@
     ExecutionResult,
     ResultMetadata,
     DuneError,
+    CreateTableResult,
 )
 from dune_client.types import QueryParameter
 from dune_client.query import DuneQuery, QueryMeta, QueryBase
@@ -279,6 +280,33 @@ def test_dune_query_from_dict(self):
         )
         self.assertEqual(expected, DuneQuery.from_dict(json.loads(example_response)))
 
+    def test_create_table_result_with_already_existed_field(self):
+        """Test CreateTableResult parsing when API response includes already_existed field"""
+        response_data = {
+            "namespace": "test_namespace",
+            "table_name": "test_table",
+            "full_name": "dune.test_namespace.test_table",
+            "example_query": "select * from dune.test_namespace.test_table limit 10",
+            "already_existed": False,
+            "message": "Table created successfully",
+        }
+        result = CreateTableResult.from_dict(response_data)
+        self.assertFalse(result.already_existed)
+
+    def test_create_table_result_missing_already_existed_field(self):
+        """Test CreateTableResult parsing when API response lacks already_existed field (verify default value)"""
+        response_data = {
+            "namespace": "test_namespace",
+            "table_name": "test_table",
+            "full_name": "dune.test_namespace.test_table",
+            "example_query": "select * from dune.test_namespace.test_table limit 10",
+            "message": "Table created successfully",
+            # Note: intentionally omitting already_existed field
+        }
+        result = CreateTableResult.from_dict(response_data)
+        # Verify default value is False
+        self.assertFalse(result.already_existed)
+
 
 if __name__ == "__main__":
     unittest.main()