Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DRY_RUN option #73

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add DRY_RUN option #73

merged 1 commit into from
Aug 22, 2024

Conversation

adammilnesmith
Copy link
Contributor

@adammilnesmith adammilnesmith commented Aug 16, 2024

Towards CHAIN-1943

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @adammilnesmith and the rest of your teammates on Graphite Graphite

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I was a little lazy in the client here by using this flag rather than just having a separate dry-run client implementation instead. Could refactor this.

Copy link
Contributor

@msf msf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, this feels lazy but in reality we have so bigger nuts to crack.. so approved

@msf msf marked this pull request as ready for review August 22, 2024 20:56
@msf msf merged commit 98adc55 into main Aug 22, 2024
1 check passed
@msf msf deleted the 08-16-add_dry_run_option branch August 22, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants