insert 1inch into binance smart chain dex trades #1229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the tests conducted:
dune_user_generated function insert_oneinch: https://dune.com/queries/976454
Inserted data: https://dune.com/queries/900194
Statistics on the dune_user_generated table: https://dune.com/queries/977445 and https://dune.com/queries/981257
I found issue with these tokens: ('\xa4b6E76bba7413B9B4bD83f4e3AA63cc181D869F', '\xe76804b43f17fc41f226d63fd2a676df409d4678', '\x587c16b84c64751760f6e3e7e32f896634704352'). Be in mind that these tokens are filtered on the statistic queries.
I think they are scam tokens, copying tokens with real value and shouldn't be on the prices.usd table. This needs to be fixed before approving the PR.
Brief comments on the purpose of your changes:
For Dune Engine V2
I've checked that:
lowercase_snake_cased
When you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.