Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert 1inch into binance smart chain dex trades #1229

Merged
merged 2 commits into from
Jul 2, 2022

Conversation

yulesa
Copy link
Contributor

@yulesa yulesa commented Jun 30, 2022

Here are the tests conducted:

dune_user_generated function insert_oneinch: https://dune.com/queries/976454
Inserted data: https://dune.com/queries/900194
Statistics on the dune_user_generated table: https://dune.com/queries/977445 and https://dune.com/queries/981257

I found issue with these tokens: ('\xa4b6E76bba7413B9B4bD83f4e3AA63cc181D869F', '\xe76804b43f17fc41f226d63fd2a676df409d4678', '\x587c16b84c64751760f6e3e7e32f896634704352'). Be in mind that these tokens are filtered on the statistic queries.
I think they are scam tokens, copying tokens with real value and shouldn't be on the prices.usd table. This needs to be fixed before approving the PR.

Brief comments on the purpose of your changes:

For Dune Engine V2
I've checked that:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased

When you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.

Here are the test conducted:

dune_user_generated function insert_oneinch: https://dune.com/queries/976454
Inserted data: https://dune.com/queries/900194
Statistics on the dune_user_generated table:  https://dune.com/queries/977445 and https://dune.com/queries/981257

I found issue with these tokens: ('\xa4b6E76bba7413B9B4bD83f4e3AA63cc181D869F', '\xe76804b43f17fc41f226d63fd2a676df409d4678', '\x587c16b84c64751760f6e3e7e32f896634704352'). Be in mind that these tokens are filtered on the statistic queries.
I think they are scam tokens, copying tokens with real value and shouldn't be on the prices.usd table. This needs to be fixed before approving the PR.
@jeff-dude jeff-dude changed the title Patch 17 insert 1inch into binance smart chain dex trades Jun 30, 2022
@jeff-dude jeff-dude mentioned this pull request Jun 30, 2022
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yulesa this should be good to go

@jeff-dude jeff-dude merged commit 0ca52c1 into duneanalytics:master Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants