erc721 category causing dupes #1231
Conversation
|
@hildobby for transparency |
| @@ -54,7 +54,7 @@ models: | |||
| - name: standard | |||
| tests: | |||
| - accepted_values: | |||
| values: ['erc721', 'erc1155' , 'erc20', 'cryptopunks','superrare'] | |||
| values: ['erc721', 'erc1155' , 'erc20', 'cryptopunks','superrare', 'unknown'] | |||
There was a problem hiding this comment.
Do we know what 'unknown' tokens are / where they come from ?
There was a problem hiding this comment.
dencentaland wearables?
There was a problem hiding this comment.
wow ok, i guess that is unknown
| 'ethereum' as blockchain, | ||
| d.hour, | ||
| b.wallet_address, | ||
| b.token_address, | ||
| b.tokenId, | ||
| nft_tokens.name as collection, | ||
| nft_tokens.category as category |
There was a problem hiding this comment.
Is deleting the whole category column the only/best way ? It seems like it's an easy/temporary fix but it would still be cool to include categories in erc721 balances. Wouldn't distinct fix it ?
There was a problem hiding this comment.
no, just a temp fix. we should try to do a group by list aggregation but I need to figure out how to do it in sparksql.
There was a problem hiding this comment.
Ok, if you think it'll take a long time to find the right fix we can push this but it made me a bit hesitant at first because it kind of feels like it wouldn't be too much work to get it fixed without excluding categories
There was a problem hiding this comment.
I'll still approve I don't want it to block you or anything
Brief comments on the purpose of your changes:
Multiple categories per collection is causing duplicate rows which our unit tests alerted us to.
I'm dropping this column until we have a fix that will convert the category column into categories.
For Dune Engine V2
I've checked that:
lowercase_snake_casedWhen you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.