balances upgrade + daily aggregation with forward fill #5464
Conversation
0xRobin
commented
Feb 28, 2024
•
0xRobin
commented
- rename some of the columns in the balances schema
- addition of daily aggregation with forward fill
0xRobin
added
ready-for-review
|
example query: https://dune.com/queries/3475840/5841282 |
| -- TODO: should not be hardcoded | ||
| WHEN type = 'native' THEN erc20_tokens.contract_address = 0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee | ||
| WHEN token_standard = 'native' THEN erc20_tokens.contract_address = 0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee |
There was a problem hiding this comment.
This will not work for Polygon I think, we should pass this in instead.
There was a problem hiding this comment.
I have only changed the column name here. 🤔
What exactly should we pass in?
There was a problem hiding this comment.
We use this for polygon https://github.com/duneanalytics/spellbook/blob/main/tokens/models/tokens/polygon/tokens_polygon_erc20.sql#L14
Most other L2s use ETH, we could actually also just pass in the the symbol and the decimal (it seems to be 8 for BNB?)
There was a problem hiding this comment.
ah ok I'll add it to the schema fix macro, ideally we would fill these values already in the raw table (instead of the current null values)
0xRobin
changed the title
