-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make macros balancer_compatible #6098
Conversation
Workflow run id 9398555531 approved. |
Workflow run id 9398555739 approved. |
Workflow run id 9398647872 approved. |
Workflow run id 9398648175 approved. |
Workflow run id 9399009891 approved. |
Workflow run id 9399009990 approved. |
Workflow run id 9399056086 approved. |
Workflow run id 9399056300 approved. |
Workflow run id 9399322950 approved. |
Workflow run id 9399323161 approved. |
Workflow run id 9399432466 approved. |
Workflow run id 9399432741 approved. |
Workflow run id 9399713472 approved. |
Workflow run id 9399713858 approved. |
Workflow run id 9399971903 approved. |
Workflow run id 9399971798 approved. |
Workflow run id 9401585899 approved. |
Workflow run id 9401586276 approved. |
Workflow run id 9594802978 approved. |
Hey, @jeff-dude! Thanks for your patience on this one. Have fixed the merge conflicts and change the models to use the reference the labels spell as
Sorry to hear that 😅! Please let me know if there's something missing on this PR in order to match the dex sector standards |
Workflow run id 9681918788 approved. |
Workflow run id 9681919107 approved. |
Workflow run id 9682360557 approved. |
Workflow run id 9682401175 approved. |
Workflow run id 9682401341 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.✅
Thank you @viniabussafi
This PR updates beethoven_x_fantom views' data as well.
thanks a lot for the review, @Hosuke! |
Thank you for contributing to Spellbook 🪄
Contribution type
Please check the type of contribution this pull request is for:
This PR updates the Balancer macros for easy integration with other chains/friendly forks, like Beethoven X on Fantom and Jellyverse on Sei and a few other ones potentially coming.
No logic changes are introduced and current results remain unaffected.
The only macro not integrated is for the liquidity spell on Fantom, due to outliers in the dex.prices table. This will be addressed in a future PR.