Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make macros balancer_compatible #6098

Merged
merged 28 commits into from
Jul 5, 2024
Merged

Conversation

viniabussafi
Copy link
Contributor

@viniabussafi viniabussafi commented Jun 6, 2024

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

This PR updates the Balancer macros for easy integration with other chains/friendly forks, like Beethoven X on Fantom and Jellyverse on Sei and a few other ones potentially coming.
No logic changes are introduced and current results remain unaffected.
The only macro not integrated is for the liquidity spell on Fantom, due to outliers in the dex.prices table. This will be addressed in a future PR.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9398555531 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9398555739 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9398647872 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9398648175 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399009891 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399009990 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399056086 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399056300 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399322950 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399323161 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399432466 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399432741 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399713472 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399713858 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399971903 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9399971798 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9401585899 approved.

@dune-eng
Copy link

dune-eng commented Jun 6, 2024

Workflow run id 9401586276 approved.

@dune-eng
Copy link

Workflow run id 9594802978 approved.

@viniabussafi
Copy link
Contributor Author

viniabussafi commented Jun 20, 2024

Hey, @jeff-dude! Thanks for your patience on this one. Have fixed the merge conflicts and change the models to use the reference the labels spell as {{ source('labels', 'balancer_v2_pools') }}. Should be good to go now.

balancer had maybe the most complex lineage to move in the dex subproject, so hopefully i didn't mess all this up too much 😅 happy to work with you on getting all of it cleaned up as needed

Sorry to hear that 😅! Please let me know if there's something missing on this PR in order to match the dex sector standards

@jeff-dude jeff-dude added ready-for-final-review and removed WIP work in progress labels Jun 24, 2024
@dune-eng
Copy link

Workflow run id 9681918788 approved.

@dune-eng
Copy link

Workflow run id 9681919107 approved.

@dune-eng
Copy link

Workflow run id 9682360557 approved.

@dune-eng
Copy link

Workflow run id 9682401175 approved.

@dune-eng
Copy link

Workflow run id 9682401341 approved.

@jeff-dude jeff-dude requested a review from Hosuke June 27, 2024 17:37
@jeff-dude jeff-dude assigned Hosuke and unassigned jeff-dude Jun 27, 2024
@jeff-dude
Copy link
Member

@Hosuke if you don't mind, can you find time soon to help review this while i'm out?
after approval, you can ask @aalan3 to help with any merges required

@Hosuke
Copy link
Collaborator

Hosuke commented Jun 27, 2024

@Hosuke if you don't mind, can you find time soon to help review this while i'm out? after approval, you can ask @aalan3 to help with any merges required

I think I will do some testing queries to check the data consistency.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @viniabussafi

This PR updates beethoven_x_fantom views' data as well.

@viniabussafi
Copy link
Contributor Author

thanks a lot for the review, @Hosuke!

@viniabussafi
Copy link
Contributor Author

viniabussafi commented Jul 4, 2024

Hey, team! Can we please merge this one anytime soon? It's holding me back on a few other things. Thank you!
@Hosuke @aalan3

@aalan3 aalan3 merged commit 0ddb1e0 into duneanalytics:main Jul 5, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants