add missing factory to curve pools #6218
Merged
+61
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workflow run id 9598904390 approved. |
|
Workflow run id 9598904837 approved. |
|
Workflow run id 9598904840 approved. |
|
Hey, @jeff-dude! can you please help out with this failed test? |
|
whew, thank you soo much for this @viniabussafi!! |
Hosuke
approved these changes
Jun 24, 2024
|
Workflow run id 9683614625 approved. |
|
Workflow run id 9683614636 approved. |
|
Workflow run id 9683614638 approved. |
|
Workflow run id 9683693733 approved. |
|
Workflow run id 9683693942 approved. |
|
Workflow run id 9683693940 approved. |
|
Workflow run id 9683716039 approved. |
|
Workflow run id 9683716296 approved. |
|
Workflow run id 9683716280 approved. |
|
Workflow run id 9683829603 approved. |
|
Workflow run id 9683829448 approved. |
|
Workflow run id 9683829605 approved. |
jeff-dude
approved these changes
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Contribution type
Please check the type of contribution this pull request is for:
For adding to existing spell lineage
If you are adding to an existing spell lineage, please provide the following information:
This PR adds the CurveStableswapFactoryNG to the curvefi_ethereum_view_pools spell, since there are some missing pools on Curve's dex trades, such as https://etherscan.io/address/0xdb74dfdd3bb46be8ce6c33dc9d82777bcfc3ded5
@mendesfabio