-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DUX-612 Gas fees revamp #6562
DUX-612 Gas fees revamp #6562
Conversation
thanks for putting this up. if you want me to help finalize while you're out, could you share which EVM chains (of all we have in spellbook) fit into which macro / logic -- if you have a list ready? |
@jeff-dude that will still require more investigation. |
dbt_subprojects/hourly_spellbook/macros/sector/gas/fees/gas_fees_arbitrum_stack.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/hourly_spellbook/macros/sector/gas/fees/gas_fees_arbitrum_stack.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/hourly_spellbook/models/_sector/gas/fees/bnb/gas_bnb_fees.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/hourly_spellbook/models/_sector/gas/fees/mantle/gas_mantle_fees.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/hourly_spellbook/models/_sector/gas/fees/zksync/gas_zksync_fees.sql
Outdated
Show resolved
Hide resolved
i'm stopping here for now, hopefully my commits didn't confuse things 🙏 |
this should be ready for a review. To summarize:
couple really simple usage examples: segmented gas fees for optimism https://dune.com/queries/4021817/6770487 currently all EVM chains except Celo are supported (awaiting investigation on raw data issues) |
amazing! i'll give a first pass, then get in front of the team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed a minor commit for DE chains, otherwise this is 🔥 implementation. thank ya!
i'll mark as ready for final review, and get florian to help us sign off on this
@0xBoxer this is ready for final review, from table output perspective. you can use this CI run to query all tables, as needed: for example, here is final gas table:
plz also note rob's comment above, which summarizes the output data well 🙏 |
i'm going to merge since we're struggling to run in CI. we can test the new output and iterate quickly on any feedback. i will link info as needed in linear to track |
Gas fees revamp [WIP]
todo's:
gas.fees
schema and spell