Convert tests to PHPUnit #17
Conversation
* Add development dependency on phpunit/phpunit ^6.0 * Update composer.lock for PHPUnit only * Add test script to composer.json and use it in .travis.yml * Put expected test results into a new directory
composer.json
Outdated
| "require-dev": { | ||
| "phpunit/phpunit": "^6.0" | ||
| }, | ||
| "scripts": { |
There was a problem hiding this comment.
Why not running phpunit directly?
There was a problem hiding this comment.
Adding the Composer script allows to easily run the correct version of PHPUnit (but also other tools such as PHPCS, should they be added in the future) without installing anything globally or modifying the PATH. See: https://getcomposer.org/doc/articles/scripts.md#writing-custom-commands
Do you want me to drop the script? (In that case, would .travis.yml require the use of vendor/bin/phpunit to work with PHPUnit 6? I'm not sure)
There was a problem hiding this comment.
Yes I prefer this way (it doesn't pollute the composer.json file with CI related commands).
There was a problem hiding this comment.
It should be fine now.
|
I just left a minor comment but it's awesome!! Thank you very much. |
|
Thank you for this tool and for the quick response. |
|
Thank you @ricordisamoa |
|
Thanks |
Uh oh!
There was an error while loading. Please reload this page.