Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TRUSTED_HOSTS and CADDY_MERCURE_PUBLIC_URL variables #591

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

J3m5
Copy link

@J3m5 J3m5 commented Mar 19, 2024

Fix issue with invalid TRUSTED_HOSTS and MERCURE_PUBLIC_URL when using http://localhost or :80 as SERVER_NAME value

Follow up of api-platform/api-platform#2666

Should I add a note in the docs @dunglas?

…_URL variables

Fix issue with invalid TRUSTED_HOSTS and MERCURE_PUBLIC_URL when using http://localhost or :80 as SERVER_NAME
@dunglas
Copy link
Owner

dunglas commented Mar 19, 2024

@J3m5 yes please!

@J3m5
Copy link
Author

J3m5 commented Mar 19, 2024

@J3m5 yes please!

The instructions has been added to the TLS documentation page.
If there's a more suitable section or page where you think this content should go, please let me know.

@maxhelias maxhelias merged commit e022f73 into dunglas:main Apr 18, 2024
2 checks passed
@maxhelias
Copy link
Collaborator

Thanks @J3m5 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants