Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon-static server capability #867

Merged
merged 1 commit into from
May 16, 2021

Conversation

hastinbe
Copy link
Contributor

Dunst supports displaying the first frame of an icon, thus it seems reasonable that it should announce that capability with icon-static.

"icon-static" | Supports display of exactly 1 frame of any given image array. This value is mutually exclusive with "icon-multi", it is a protocol error for the server to specify both.
from https://developer.gnome.org/notification-spec/#hints

I check for this capability in another project. notify-osd is the only other I know that supports/announces it, however dunst doesn't when it could since it has this already. I've been relying upon the image-path hint as an alternative which is more or less a fire and forget approach but it'd be nice to know if the capability exists

Dunst supports displaying the first frame of an icon, thus it should
announce that capability.
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2021

Codecov Report

Merging #867 (bd6abfc) into master (f2017eb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
+ Coverage   58.54%   58.55%   +0.01%     
==========================================
  Files          37       37              
  Lines        5987     5989       +2     
==========================================
+ Hits         3505     3507       +2     
  Misses       2482     2482              
Flag Coverage Δ
unittests 58.55% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dbus.c 63.14% <100.00%> (+0.11%) ⬆️
test/dbus.c 98.67% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2017eb...bd6abfc. Read the comment docs.

@fwsmit
Copy link
Member

fwsmit commented May 16, 2021

I didn't know we supported this :-)
LGTM, thank you.

@fwsmit fwsmit merged commit cb6f2ca into dunst-project:master May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants