xdg-open can open URLs, don't rely on specific hardcoded browser. #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebehei
approved these changes
Jul 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
=======================================
Coverage 60.18% 60.18%
=======================================
Files 39 39
Lines 6181 6181
=======================================
Hits 3720 3720
Misses 2461 2461
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
PR looks good. I agree that it's better to use xdg-open. Could you add xdg-open as an optional dependency in the readme? |
|
Conflicts with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.