wayland: fix dunst crashing when sending notification with no outputs enabled #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enabled This commit does mess up the foreign toplevel support, however. No fullscreen detection anymore
|
I can confirm this fixes the crash for me. |
fwsmit
force-pushed
the
fix/wl_no_output_crash
branch
from
d2b4930
to
d24d2a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #930 +/- ##
==========================================
- Coverage 60.91% 60.35% -0.57%
==========================================
Files 39 40 +1
Lines 6355 6414 +59
==========================================
Hits 3871 3871
- Misses 2484 2543 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is mostly taken from examples/foreign-toplevel.c of wlroots.
fwsmit
force-pushed
the
fix/wl_no_output_crash
branch
from
d24d2a7
to
0671c09
Compare
Thanks for testing, I'll merge it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does mess up the foreign toplevel support, however. So no fullscreen detection anymore. I'll fix that later.
Fixes #888
Edit: I also fixed the fullscreen detection