Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFIgy considers beta builds out of date. #2

Closed
PokeCaptain opened this issue Jan 5, 2018 · 4 comments
Closed

EFIgy considers beta builds out of date. #2

PokeCaptain opened this issue Jan 5, 2018 · 4 comments
Assignees

Comments

@PokeCaptain
Copy link

Example video is in the link.
Just reran using the build that came out today.
https://drive.google.com/file/d/1L2sZKmp5JUz4ROntdIQsVgxLee0ubAou/view?usp=sharing

@PokeCaptain
Copy link
Author

Just realized, should be a simple fix. Just check if the Build Number represented in hex is greater than or equal to the expected value. If so, it passes.

@swrobel
Copy link

swrobel commented Jan 27, 2018

Well, now the app is failing with 10.3.3 which is the actual latest macOS. It doesn't seem to recognize that 10.3.3 > 10.3.2 so it tells me I'm "out of date." Guys, I really appreciate what you're trying to do here, but I fear that you've done such a slapshod job that this tool is potentially doing more harm than good.

@futureimperfect
Copy link
Contributor

@PokeCaptain @swrobel Thanks for the feedback!

Currently EFIgy-GUI compares the local results to what is returned from the EFIgy API, so if the version(s) returned by the API don't match what we get locally then you'll see these issues. I'll have a chat with @MyNameIsMeerkat and @bruienne about the best way to solve this.

Thanks again!

@futureimperfect
Copy link
Contributor

This should be resolved now, but feel free to reopen if not. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants