Skip to content
This repository has been archived by the owner on Aug 2, 2018. It is now read-only.

Trigger compatibility mode on certain CSS components #286

Merged
merged 4 commits into from
Sep 3, 2014

Conversation

matthewmueller
Copy link
Contributor

This PR helps ease the transition for Component users. This PR adds compatibility support for Components that have multiple styles or have CSS dependencies. Some of the Components that Duo should now support:

https://github.com/suitcss/theme
https://github.com/component/prompt-popover
https://github.com/component/prompt-popover
https://github.com/component/datepicker
https://github.com/component/dropdown
https://github.com/yields/select
https://github.com/yields/skeleton

Now, I'd like to remove this at some point, as it's a bit of a hack. But we'll need to come up with a good transition route to get everyone moved over.

Most of the tests are in css-compat. Head over there for more info.

Closes: #252

@matthewmueller
Copy link
Contributor Author

Thanks for helping me sort through these issues @lancejpollard and @stephenmathieson !

matthewmueller added a commit that referenced this pull request Sep 3, 2014
Trigger compatibility mode on certain CSS components
@matthewmueller matthewmueller merged commit 71d98d1 into master Sep 3, 2014
@matthewmueller matthewmueller deleted the add/component-css-compat branch September 3, 2014 06:45
@stephenmathieson
Copy link
Contributor

nice!!

@ismay
Copy link

ismay commented Sep 8, 2014

This is great! I've been having some issues with the suitcss components and their dependencies (like suitcss/base, which requires normalize.css), but now it all works as expected!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support css in manifest
3 participants