Skip to content
This repository has been archived by the owner on Oct 5, 2023. It is now read-only.

Setup ClassworkSubmission model and Comment module #368

Merged
merged 10 commits into from
May 31, 2021

Conversation

canhuyh
Copy link
Collaborator

@canhuyh canhuyh commented May 27, 2021

ResolveField comment will be updated in task Implement commentService.listCommentByTargetId

Link task: https://app.clickup.com/t/8u0cwc

@vercel
Copy link

vercel bot commented May 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/withdustin/kathena-ui/7QArQTe59auhnUouUb5vPy7MD3GM
✅ Preview: https://kathena-ui-git-cu-8u0cwc-be-setup-submit-model-and-c-639d02.vercel.app

@duongdev
Copy link
Owner

@duongdev duongdev temporarily deployed to kathena-pr-368 May 27, 2021 08:08 Inactive
@canhuyh canhuyh changed the title [WIP] Setup Submit model and Comment module Setup Submit model and Comment module May 27, 2021
Copy link
Collaborator

@nguyenvanhai-0911 nguyenvanhai-0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Đợi anh Dương xem ý của ảnh như nào.

packages/server/src/modules/classwork/models/Submit.ts Outdated Show resolved Hide resolved
@nguyenvanhai-0911
Copy link
Collaborator

Đợi anh Dương xem ý của ảnh như nào.

@duongdev duongdev temporarily deployed to kathena-pr-368 May 28, 2021 01:32 Inactive
@duongdev duongdev temporarily deployed to kathena-pr-368 May 28, 2021 01:33 Inactive
@canhuyh canhuyh changed the title Setup Submit model and Comment module [WIP] Setup Submit model and Comment module May 28, 2021
@duongdev duongdev temporarily deployed to kathena-pr-368 May 28, 2021 03:33 Inactive
@duongdev duongdev temporarily deployed to kathena-pr-368 May 28, 2021 10:05 Inactive
@duongdev duongdev temporarily deployed to kathena-pr-368 May 28, 2021 14:12 Inactive
@duongdev duongdev temporarily deployed to kathena-pr-368 May 30, 2021 10:16 Inactive
@canhuyh canhuyh changed the title [WIP] Setup Submit model and Comment module Setup Submit model and Comment module May 30, 2021
@canhuyh canhuyh changed the title Setup Submit model and Comment module Setup ClassworkSubmission model and Comment module May 31, 2021
packages/server/src/core/app/app.module.ts Show resolved Hide resolved
@@ -39,7 +25,13 @@ export class ResultClassworkUnionResolver {
return ['ClassworkMaterial', 'ClassworkAssignment']
}

// This needs to be edited
@ResolveField((_returns) => [Comment])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

này là sao á ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

này đang để đó thôi, sẽ update sau, tui có comment phía trên cùng của PR này á

@kodiakhq kodiakhq bot merged commit d65d00e into main May 31, 2021
@kodiakhq kodiakhq bot deleted the CU-8u0cwc-BE-Setup-Submit-model-and-Comment-module branch May 31, 2021 04:45
danghieuliem added a commit that referenced this pull request May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants