wrapped get_permalink in filter to make it possible to manipulate url #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code for 1.5 has been finalized, some testing still has to be done. Would you mind if I would only merge this to v1.6? This means that after v1.5 has been released, you will still need to patch the plugin but after this I am open to merge this into the core. |
|
Yeah that is fine. thanks |
|
Since a lot has been changed in woocommerce.php since your commit, I added this filter manually: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all get_permalink() calls to apply_filters( 'the_permalink', get_permalink() ).
This was necessary as we were manipulating the url via this filter but this plugin wouldn't change the permalink.
Thanks