-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds docker #50
Merged
Merged
Adds docker #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fozboz
reviewed
Nov 9, 2021
common/src/main/java/org/duracloud/mill/util/CommonCommandLineOptions.java
Outdated
Show resolved
Hide resolved
fozboz
reviewed
Nov 10, 2021
fozboz
reviewed
Nov 10, 2021
fozboz
reviewed
Nov 10, 2021
dbernstein
force-pushed
the
add-docker
branch
from
November 12, 2021 20:46
fd0c485
to
f999e2a
Compare
bbranan
reviewed
Jan 13, 2022
bbranan
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me @dbernstein, sorry it took so long to get to a review. I'd only suggest dropping the dockerhub script (to avoid future confusion) before a merge.
…ion will likely move to the terraform project
dbernstein
force-pushed
the
add-docker
branch
from
January 26, 2022 17:48
f999e2a
to
1a3c295
Compare
@bbranan : this should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update includes all changes required to run the mill in docker.
The docker image contains all the binaries and scripts required to run all of the various nodes that comprise the mill. Which node the docker container is running as depends on the $NODE_TYPE environment variable which can be set to any of the following values:
To build the docker container:
This is how I'm running it in duracloud-aws-deployer:
Notice
-v /sys/fs/cgroup/:/sys/fs/cgroup:ro --cap-add SYS_ADMIN
:This is necessary to get cron to work on the nodes that require it (namely the sentinel). It should be noted that the volume mapping is specific to debian.