Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binaryerr›› should detect if Version is not supported #17

Closed
duraki opened this issue Aug 28, 2020 · 3 comments · Fixed by #20
Closed

binaryerr›› should detect if Version is not supported #17

duraki opened this issue Aug 28, 2020 · 3 comments · Fixed by #20

Comments

@duraki
Copy link
Owner

duraki commented Aug 28, 2020

Due to #15 and #16, we need to add support for binaryerr to check supported hashes via binary Mach-O, and report the end-user that the version is not yet supported.

ie. If hash is not in the list, nor does match supported version, it's probably:

  • an unsupported version
  • a broken binary
+ Issue details ‹s:sketchcrapp›
+ Application Path  : /Users/xxxx/Downloads/Sketch.app
+ Application Binary: /Users/xxxx/Downloads/Sketch.app/Contents/MacOS/Sketch
+ Passed version    : ‹nil›
+ Binary SHA1       : bc22987f7b3a7580aba1ac260c59d66d0a3622e7
+ Error             : binaryerr›› [version not supported]
+                     supported versions are [v1, ..., v(n)]
+===================================================================

We can further read *.plist under app directory to detect which version did user try to patch. This way we can diff between a broken binary or given version. For example, if plist version is supported (ie. v61.1), it's a broken binary; if plist version is not yet supported, it needs a SketchCrapp update and obviously some more reverse-engineering.

[version v(n) is not yet supported]

@elijahtsai wdyt?

@duraki duraki added the New Version Request New feature or request is need label Aug 28, 2020
@elijahtsai
Copy link
Collaborator

This is totally what I think!!!😂

@duraki
Copy link
Owner Author

duraki commented Aug 31, 2020

That was fast :) Nice work @elijahtsai! 🚀

@elijahtsai
Copy link
Collaborator

Haha! closed 3 issue a day, never tried

elijahtsai added a commit that referenced this issue Oct 31, 2020
Sync with original repository.
@elijahtsai elijahtsai removed the New Version Request New feature or request is need label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants