Add Libcxx Compatability Mode to AnyBlob #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagjamin
added a commit
to wagjamin/perfevent
that referenced
this pull request
Nov 24, 2023
When building `PerfEvent.hpp` with `libcxx`, compilation fails. This is because we are not including the `sstream` header. This commit adds the missing include, allowing `PerfEvent.hpp` to build with `libcxx`. We ran into this issue while filing: durner/AnyBlob#3
|
I just filed viktorleis/perfevent#8 to make sure we can get around the nasty include ordering requirement for some of the tests. |
durner
reviewed
Nov 24, 2023
| @@ -1,3 +1,7 @@ | |||
| // Sadly, the include order matters here. PerfEvent depends on sstream but | |||
| // does not include the header. | |||
| #include <sstream> | |||
There was a problem hiding this comment.
Already filed the PR :-P
| // Sadly, the include order matters here. PerfEvent depends on sstream but | ||
| // does not include the header. | ||
| #include <sstream> | ||
|
|
I just wanted to do the same. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Overview
At the moment, AnyBlob can only link against the gnu standard library.
This commit adds a new CMake option
ANYBLOB_LIBCXX_COMPATthat allowsbuilding AnyBlob while linking against
libcxx.Detailed Changes
The main changes in this commit are:
when including the libcxx headers, as a result some string headers
were missing in some places.
ThroughputResolverwhen building with libcxx. This is themore invasive of the two changes. The
ThroughputResolverdepends on__gnu_pbds::tree, which is not spported in libcxx. When building inlibcxx compatibility mode, we now remove this resolve completely. In
this case, the
io_uring_socket.cppfalls back onto the defaultresolver.
To ease reviewing, the PR is split into two commits. The first commit contains
the code changes to get AnyBlob to build with
libcxx. The second commitcontains the CI changes.
Test Plan
mode.
with
clang-15and the libcxx compatibility mode.clang-15andlibc++, running both unit and integration tests.