Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plonk zexe #41

Merged
merged 17 commits into from
Apr 15, 2020
Merged

Plonk zexe #41

merged 17 commits into from
Apr 15, 2020

Conversation

vlopes11
Copy link
Contributor

@vlopes11 vlopes11 commented Apr 3, 2020

No description provided.

@vlopes11 vlopes11 self-assigned this Apr 3, 2020
@CPerezz
Copy link
Contributor

CPerezz commented Apr 6, 2020

LGTM. Build failed due to the long time to run the tests/benches

@ZER0
Copy link
Contributor

ZER0 commented Apr 8, 2020

Let's check with @Fulviuus if we can increase the timeout specifically for this repo / project; or if we can skip some test only if we're in travis.

@CPerezz
Copy link
Contributor

CPerezz commented Apr 15, 2020

Let's check with @Fulviuus if we can increase the timeout specifically for this repo / project; or if we can skip some test only if we're in travis.

I haven't seen this option TBH, but maybe it's possible.
Anyway, we could maybe just ignore the test that is exceeding the time or decrease the degree of the circuit done inside.

I just verified that is running in release mode, so much more we can do on the Travis config side. I've seen this https://docs.travis-ci.com/user/common-build-problems/#my-builds-are-timing-out maybe @Fulviuus can take a look.

@vlopes11
Copy link
Contributor Author

This travis time limit issue is out of scope of this pull request. I'll proceed with the merge so we can plan the next step (integrate with plonk master)

@vlopes11 vlopes11 merged commit 95048a9 into master Apr 15, 2020
@CPerezz CPerezz mentioned this pull request Apr 15, 2020
@CPerezz CPerezz deleted the plonk_zexe branch April 26, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants