Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Merge request for past and current commits. #71

Merged
merged 7 commits into from
Jul 25, 2019
Merged

Merge request for past and current commits. #71

merged 7 commits into from
Jul 25, 2019

Conversation

LukePearson1
Copy link
Contributor

The first few at the top are just the rectifications of your comments on my last merge conflicts.
The last are code additions, with what is now verified curve proofs for Doppio.

@LukePearson1 LukePearson1 added documentation Improvements or additions to documentation research Need to research about this. labels Jul 23, 2019
@LukePearson1 LukePearson1 changed the title Merge request Merge request for past and current commits. Jul 23, 2019
@CPerezz
Copy link
Contributor

CPerezz commented Jul 23, 2019

Build is failing. I'll check the logs so you can solve the errors.

Also, it will be nice to add better titles and descriptions of the PR and what does it include or remove.

sage_codes/Safe Curve code Outdated Show resolved Hide resolved
sage_codes/Safe Curve code Outdated Show resolved Hide resolved
sage_codes/Safe Curve code Outdated Show resolved Hide resolved
src/backend/u64/mod.rs Show resolved Hide resolved
@CPerezz
Copy link
Contributor

CPerezz commented Jul 24, 2019

The build is failing since it was removed the following compiler instruction:
#[cfg(not(any(feature = "u64_backend")))] found at src/backend/u64/mod.rs .

Is there any reason why this was removed? Since this instruction forces the compiler to use the u64_backend if no feature has been selected.

This commit is related to
W Please enter the commit message for your changes. Lines starting
@CPerezz CPerezz self-requested a review July 25, 2019 18:07
@CPerezz CPerezz merged commit a4713ed into dusk-network:master Jul 25, 2019
CPerezz added a commit that referenced this pull request Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation research Need to research about this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants