Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add owns and owns_unchecked to SecretKey #216

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Add owns and owns_unchecked to SecretKey #216

merged 2 commits into from
Jun 17, 2024

Conversation

xevisalle
Copy link
Member

@xevisalle xevisalle commented Jun 17, 2024 •
edited
Loading

Resolves: #146

HDauven
HDauven approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 for the clear variable naming

@xevisalle xevisalle changed the title core: Add owns and owns_unchecked to SecretKey Add owns and owns_unchecked to SecretKey Jun 17, 2024
@xevisalle xevisalle merged commit 049a6b4 into master Jun 17, 2024
6 checks passed
@xevisalle xevisalle deleted the sk_owns branch June 17, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDauven HDauven HDauven approved these changes

@ureeves ureeves Awaiting requested review from ureeves

@moCello moCello Awaiting requested review from moCello

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SecretKey should be enough to verify note's ownership
2 participants
@xevisalle @HDauven