Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation of the concepts behind PLONK #628

Closed
wants to merge 2 commits into from
Closed

Conversation

moCello
Copy link
Member

@moCello moCello commented Nov 3, 2021

No description provided.

@moCello moCello linked an issue Nov 3, 2021 that may be closed by this pull request
@moCello moCello added area:documentation Anything to improve our doc base team:Core Low Level Core Development Team (Rust) labels Nov 3, 2021
@moCello moCello closed this Nov 11, 2021
@moCello moCello reopened this Nov 11, 2021
@moCello moCello changed the title Change documentation for better math rendering Add documentation of the concepts behind PLONK Nov 11, 2021
@moCello moCello added the type:docs deliverable should be documentation label Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #628 (a463fae) into master (282221d) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a463fae differs from pull request most recent head 7c75cb9. Consider uploading reports for the commit 7c75cb9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
- Coverage   97.71%   97.71%   -0.01%     
==========================================
  Files          54       54              
  Lines        4067     4066       -1     
==========================================
- Hits         3974     3973       -1     
  Misses         93       93              
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (ø)
src/permutation.rs 99.30% <0.00%> (-0.01%) ⬇️
src/fft/evaluations.rs 100.00% <0.00%> (ø)
src/proof_system/widget.rs 98.58% <0.00%> (ø)
src/constraint_system/composer.rs 98.05% <0.00%> (ø)
src/fft/polynomial.rs 96.20% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2443c8...7c75cb9. Read the comment docs.

<p align=center>
<img src="https://upload.wikimedia.org/wikipedia/commons/c/c2/Triangulation_3-coloring.svg" alt="drawing" width="35%"/>
</p>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason you didn't use the markdown way of including the picture of the graph? Did it not render?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to center it and also to specify the size, to fit in different screens, and using html tags was the solution I found for it... if you know an alternative, let me know :)

docs/zero_knowledge.md Outdated Show resolved Hide resolved
docs/zero_knowledge.md Outdated Show resolved Hide resolved
docs/zero_knowledge.md Outdated Show resolved Hide resolved
docs/zero_knowledge.md Outdated Show resolved Hide resolved
docs/zero_knowledge.md Outdated Show resolved Hide resolved
@xevisalle
Copy link
Member

Closing since the docs were removed.

@xevisalle xevisalle closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Anything to improve our doc base team:Core Low Level Core Development Team (Rust) type:docs deliverable should be documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation touch-up
2 participants