Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support Google Shared Drives #390

Open
wc7086 opened this issue Jul 21, 2021 · 9 comments
Open

Feature: support Google Shared Drives #390

wc7086 opened this issue Jul 21, 2021 · 9 comments

Comments

@wc7086
Copy link
Contributor

wc7086 commented Jul 21, 2021

Google shared drives can have unlimited storage space. Using rclone requires more steps, so I hope transfer.sh can directly support it.

Google shared drives API Docs: https://developers.google.com/drive/api/v3/enable-shareddrives

Create Google Shared Drives for free: https://td.msgsuite.workers.dev/

@wc7086 wc7086 changed the title support Google Shared Drives Feature: support Google Shared Drives Jul 22, 2021
@stefanbenten
Copy link
Collaborator

@wc7086 Could you elaborate the use case a little more?
Transfer.sh original itention is not to be come an archival sharing service. There might be forks running as such, but that defeats the purpose in my mind.
What are your thoughts on this @aspacca ?

@wc7086
Copy link
Contributor Author

wc7086 commented Aug 13, 2021

@wc7086 Could you elaborate the use case a little more?

https://github.com/rclone/rclone/blob/master/backend/drive/drive.go

Although it can be mounted directly with rclone, it is inconvenient to use docker in this way.

@aspacca
Copy link
Collaborator

aspacca commented Aug 15, 2021

@stefanbenten the reason to support gdrive shared drives is to have unlimited storage (like some of them have), as far as I understand.

I see value i this: I have to investigate what are the requirements, hopefuly just the proper oauth2 scope, that would be an easy fix but would required reauthenticating the client

@aspacca
Copy link
Collaborator

aspacca commented Aug 15, 2021

actually it seems even simplier: we have to provide a param for the drive id to use, that could be a shared one.
I have to check how client app can join a share drive, @wc7086 any clue?

@hongkongkiwi
Copy link

Any progress on this?

@aspacca
Copy link
Collaborator

aspacca commented Sep 12, 2022

@hongkongkiwi
I have no shared folder to test on

you can try to write the ID of the folder in the shared drive (ie: --basedir) in %gdrive-local-config-path%root_id.conf and see if it works

@jonasled
Copy link

jonasled commented Dec 1, 2022

Nope, this doesn't work

@aspacca
Copy link
Collaborator

aspacca commented Dec 1, 2022

@jonasled thanks for testing

There's a PR to support shared drives on gdrive: #512

As it is, it introduces breaking change and I cannot merge to main without getting rid of them.

If the original author won't give feedback in a reasonable time I will follow up with the development

@aspacca
Copy link
Collaborator

aspacca commented Dec 1, 2022

actually it seems even simplier: we have to provide a param for the drive id to use, that could be a shared one.

I totally forgot about the investigation I did and how I came to this conclusion: this solution joint with the most of the code already in #512 seems to be the proper one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants