Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the prop reassign ( props are read only ) #1

Closed
wants to merge 3 commits into from
Closed

Fixes the prop reassign ( props are read only ) #1

wants to merge 3 commits into from

Conversation

romulobordezani
Copy link

The reassign is impossible because props are read-only, according to react-docs (https://reactjs.org/docs/components-and-props.html#props-are-read-only).
It fixes an error that occurs when FB-GRID is reloaded linked to a theme.

The reassign is impossible because props are read-only, according to react-docs (https://reactjs.org/docs/components-and-props.html#props-are-read-only).
 It fixes an error that occurs when FB-GRID is reloaded linked to a theme.
@coveralls
Copy link

coveralls commented Jun 3, 2018

Pull Request Test Coverage Report for Build 16

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 96.667%

Totals Coverage Status
Change from base Build 13: -3.3%
Covered Lines: 20
Relevant Lines: 20

💛 - Coveralls

@ghost
Copy link

ghost commented Jun 3, 2018

Diogão, rodando os testes aqui na minha máquina continua com 100% o coverage. Porém no Travis baixou 3%. Estranho. Depois vemos isso juntos ;)

@romulobordezani
Copy link
Author

Mano, precisei adicionar mais um lancezinho, uma classe nas celulas chamada e-grid pra formatar via Elem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants