-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: open redux-devtool trace history #2096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorrycc
requested changes
May 9, 2019
packages/dva-core/src/createStore.js
Outdated
@@ -29,7 +29,7 @@ export default function({ | |||
const composeEnhancers = | |||
process.env.NODE_ENV !== "production" && | |||
window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ | |||
? window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ | |||
? window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__({ trace: true,maxAge:30 }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true,
后加个空格。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
空格已经加上,lint-staged
自动补入了当前文件line19
的一个分号,又Get一个新东西
sorrycc
changed the title
open redux-devtool trace history
feat: open redux-devtool trace history
May 10, 2019
|
GoToBoy
pushed a commit
to GoToBoy/dva
that referenced
this pull request
Oct 12, 2023
* open redux-devtool trace history * '空格'
GoToBoy
pushed a commit
to GoToBoy/dva
that referenced
this pull request
Oct 12, 2023
* open redux-devtool trace history * '空格'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加
Redux
调试面板trace
调用记录Redux
面板trace
的开关,保留默认10
条记录Checklist
Description of change
dva-core/src/createStore.js
before
after
首先
dva
非常好用但是在现在开发的项目中
model
定义超过100个,由不同的开发人员进行开发,在调度model
上各不同,调试变得略微麻烦,在找寻解决方法时发现redux
有提供调用追踪,并在项目中使用,对于项目中追踪调度和调试还有有效率上的改变,所以希望能在dva
这么一个优秀的开源项目中提供一PR
,享受更便捷的调试