Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: window 会在小程序里报错 #2194

Merged
merged 1 commit into from
Sep 5, 2019
Merged

fix: window 会在小程序里报错 #2194

merged 1 commit into from
Sep 5, 2019

Conversation

yesmeck
Copy link
Contributor

@yesmeck yesmeck commented Sep 5, 2019 •
edited
Loading

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

小程序里不允许变量名叫 window

\cc @army8735

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.681% when pulling 9edf485 on yesmeck:rename-window into f964508 on dvajs:master.

@sorrycc sorrycc added the pr(bug) label Sep 5, 2019
@sorrycc sorrycc merged commit 617e678 into dvajs:master Sep 5, 2019
@sorrycc
Copy link
Member

sorrycc commented Sep 5, 2019

  • dva-core@2.0.0
  • dva@2.6.0-beta.14

GoToBoy pushed a commit to GoToBoy/dva that referenced this pull request Oct 12, 2023
@yesmeck @sorrycc
fix: window 会在小程序里报错 (dvajs#2194)
c2dfc05
GoToBoy pushed a commit to GoToBoy/dva that referenced this pull request Oct 12, 2023
@yesmeck @sorrycc
fix: window 会在小程序里报错 (dvajs#2194)
08f72be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr(bug)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yesmeck @coveralls @sorrycc