feat: support react 18 #2515
Merged
feat: support react 18 #2515
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorrycc
requested changes
May 6, 2024
sorrycc
requested changes
May 7, 2024
package.json
Outdated
Comment on lines
46
to
47
| "repository": "git@github.com:jasonzhuang/dva18.git" | ||
| } |
.gitignore
Outdated
| @@ -8,3 +8,4 @@ | |||
| /packages/**/node_modules | |||
| /packages/**/dist | |||
| /lerna-debug.log | |||
| .history/ | |||
There was a problem hiding this comment.
我先删掉。但实际上最好有这个说明，不然vscode有些装了这个插件的，会默认生成
packages/dva/src/index.js
Outdated
| @@ -20,7 +20,7 @@ const { connectRouter, routerMiddleware } = routerRedux; | |||
| const { isFunction } = utils; | |||
| const { useHistory, useLocation, useParams, useRouteMatch } = router; | |||
|
|
|||
| export default function(opts = {}) { | |||
| export default function (opts = {}) { | |||
There was a problem hiding this comment.
不要做风格调整，应该是你本地的 prettier 和 dva 的 prettier 版本不一致。
There was a problem hiding this comment.
done, 暂时把vscode上formatOnSave关闭了解决
.prettierrc
Outdated
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "printWidth": 100, | |||
| "singleQuote": true, | |||
| "trailingComma": "all" | |||
| "trailingComma": "all", | |||
| "semi": true | |||
sorrycc
approved these changes
May 10, 2024
|
Bumped dva@3.0.0-alpha.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
升级react版本，在依赖react-dom的地方升级了用法，使用creatRoot来渲染
Close #2514