Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support Irish grid #2

Closed
robations opened this issue Oct 21, 2015 · 4 comments
Closed

Feature request: support Irish grid #2

robations opened this issue Oct 21, 2015 · 4 comments

Comments

@robations
Copy link

As far as I can tell (I don't have much experience with GIS) this would be very similar or the same as the OSRef, just with a few different constants. I've been trying to follow along here to implement this:

https://www.ordnancesurvey.co.uk/docs/support/guide-coordinate-systems-great-britain.pdf

though so far pretty confused by the various standards, and statements like "this is not a transformation", which begs the question, "what is and isn't a transformation?".

@robations
Copy link
Author

I managed to implement this by copying the OSRef class as IrishGridRef and changing the relevant constants. It seems to work, at least to the low precision I need at the moment.

Obviously this isn't a maintainable solution, but doing this properly will need some refactoring to avoid repeating all the logic that's currently in OSRef::toLatLng(). If you're interested I could perhaps look at this and submit a PR.

@dvdoug
Copy link
Owner

dvdoug commented Oct 25, 2015

Yes, I'd happily take a PR to add support

@dvdoug
Copy link
Owner

dvdoug commented Jan 3, 2016

Now available in v2, but please note I refactored and changed the API a bit so it's not a drop-in upgrade

@dvdoug dvdoug closed this as completed Jan 3, 2016
@robations
Copy link
Author

That's great — I didn't ever get back to this and I've been avoiding coding outside work for sanity reasons :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants