go-fuzz-build: set GO111MODULE=off while building #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates dvyukov#195 Updates google/oss-fuzz/pull#2188
|
I wonder whether we also need GO111MODULE=off during our calls to go list. Ugh. |
|
Wouldn't it be better pass the systems environment vars? Then one could run the command(s) with |
|
Actually, you can already do that as the existing code appends to the systems environment. NVM. |
FWIW, I suspect the current fix is not quite right. GO111MODULE=off would likely need to be set for any calls to |
josharian
added a commit
to josharian/go-fuzz
that referenced
this pull request
May 3, 2019
This is a follow-up to dvyukov#237. Updates dvyukov#195 Updates google/oss-fuzz/pull#2188
bradleyjkemp
pushed a commit
to bradleyjkemp/simple-fuzz
that referenced
this pull request
Oct 23, 2019
This is a follow-up to dvyukov#237. Updates dvyukov#195 Updates google/oss-fuzz/pull#2188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #195
Updates google/oss-fuzz/pull#2188
I'm genuinely unsure what other consequences this change might have. But since our module support is busted anyway, I suspect that this will at least make things no worse, and may fix some builds.